From: Paul H. Hargrove (PHHargrove_at_lbl_dot_gov)
Date: Tue Nov 10 2009 - 13:10:40 PST
Alan Woodland wrote: > 2009/11/2 Stefan Kluth <[email protected]>: > >> Hi Alan, >> >> the vanilla blcr 0.8.2 from >> >> https://ftg.lbl.gov/CheckpointRestart/CheckpointRestart.shtml >> >> build and check fine on ubuntu hardy, if that is of any consolation to you. >> >> For karmic (sid) I guess I'll have to wait for a new package ... I am happy >> to run some tests if that is needed. >> >> > Just to confirm - 0.8.2-5, which includes the 2.6.31 patches should > hit the Debian archive tonight, is in http://incoming.debian.org at > the moment and works fine on Ubuntu Karmic with the 2.6.31 kernel. > > The tests passed, except prctl(). The problem with the prctl test is > actually that the configure test lives inside the "if cr_build_libcr" > conditional, but I've been using --with-installed-libcr because the > tests are the only part of the package that doesn't end up in a Debian > package. If I don't configure with this flag it passes. I guess the > fix is to either always run this test in configure, or do it when > building one of the tests or the library? > > Alan > OK, so I thing I messed up putting the HAVEW_PRCTL configure probe conditional on cr_build_libcr, when it should probably have been conditional on cr_build_tests. The attached patch should resolve that. However, IIRC this test should be printing "SKIPPED" rather than "FAIL" if the configure probe failed (or in this case it was not run). Is that right? -Paul -- Paul H. Hargrove PHHargrove_at_lbl_dot_gov Future Technologies Group Tel: +1-510-495-2352 HPC Research Department Fax: +1-510-486-6900 Lawrence Berkeley National Laboratory Index: configure.ac =================================================================== RCS file: /var/local/cvs/lbnl_cr/configure.ac,v retrieving revision 1.410.2.12 diff -u -p -r1.410.2.12 configure.ac --- configure.ac 8 Nov 2009 01:50:20 -0000 1.410.2.12 +++ configure.ac 10 Nov 2009 21:09:44 -0000 @@ -561,17 +561,6 @@ LIBS="-lpthread $LIBS" AC_CHECK_FUNCS([pthread_attr_setstacksize]) LIBS="$SAVE_LIBS" -# Look for prctl(PR_SET_PDEATHSIG, ...) -AC_CACHE_CHECK([[for pctrl()]], cr_cv_prctl, [ - AC_TRY_COMPILE([ - #include <sys/prctl.h> - ], [ - int rc = prctl(PR_SET_PDEATHSIG, 0); - ], [cr_cv_prctl=yes], [cr_cv_prctl=no]) -]) -CR_DEFINE(HAVE_PRCTL,[test x$cr_cv_prctl = xyes], - [Define to 1 if prctl() function is available.]) - # Check various constants needed for asm SAVE_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -I${TOP_SRCDIR}/include" @@ -675,6 +664,20 @@ CR_STACK_DIRECTION fi # cr_build_libcr +if test x"$cr_build_tests" = xyes; then +# Look for prctl(PR_SET_PDEATHSIG, ...) +AC_CACHE_CHECK([[for pctrl()]], cr_cv_prctl, [ + AC_TRY_COMPILE([ + #include <sys/prctl.h> + ], [ + int rc = prctl(PR_SET_PDEATHSIG, 0); + ], [cr_cv_prctl=yes], [cr_cv_prctl=no]) +]) +CR_DEFINE(HAVE_PRCTL,[test x$cr_cv_prctl = xyes], + [Define to 1 if prctl() function is available.]) + +fi # cr_build_tests + # Probe libc for the RT signal number to use CR_CHECK_SIGNUM