Re: Problems with 32bit Fedora 7

From: John Hodrien (johnh_at_comp.leeds.ac.uk)
Date: Thu Aug 30 2007 - 05:43:30 PDT

  • Next message: Paul H. Hargrove: "Re: Problems with 32bit Fedora 7"
    On Thu, 30 Aug 2007, Paul H. Hargrove wrote:
    
    > I had already added code (only barely tested) to perform the relocation of 
    > our symbols captured from System.map, but did not fix the validation step. 
    > Since relocations need to obey the compiled-in PHYSICAL_ALIGN restriction, it 
    > should be easy to validate that the symbols differ from System.map by only a 
    > legal offset.
    >
    > John,
    >  Please try building from a BLCR source tarball with the attached patch 
    > applied (and not using kallsyms) and let me know if it works.
    
    Sure.  The patch was nearly right bar a typo, as it should be
    CONFIG_PHYSICAL_ALIGN I assume, rather than PHYSICAL_ALIGN.  I'm also guessing
    at that being a bitwise and.  That then becomes:
    
    #if defined(CONFIG_RELOCATABLE) && defined(CONFIG_PHYSICAL_ALIGN)
             unsigned long unaligned = offset1 & (CONFIG_PHYSICAL_ALIGN - 1);
    
    Which seems to work nicely.  Is that fix correct?
    
    jh
    
    -- 
    "Nostaligia's not what it used to be."               -- Anon.
    

  • Next message: Paul H. Hargrove: "Re: Problems with 32bit Fedora 7"